Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GIT PULL] Link against libgcc based on output of -print-libgcc-file-name #1016

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[GIT PULL] Link against libgcc based on output of -print-libgcc-file-name #1016

merged 1 commit into from
Dec 18, 2023

Conversation

vimproved
Copy link
Contributor

@vimproved vimproved commented Dec 16, 2023 •
edited
Loading

GCC and clang have the -print-libgcc-file-name option to automatically print out the correct compiler runtime library to link to. This can be helpful in case the runtime library is named something other than libgcc (i.e. on a system where only LLVM's compiler-rt is used), or if libgcc is in a non-standard directory. If the option fails for whatever reason, fall back to using "-lgcc".

git request-pull output:

The following changes since commit 92b21aa1b4ea98e322c5eca9db1d94b837f4be75:

  Rename ffi io_uring_prep_sock_cmd _> io_uring_prep_cmd_sock() (2023-12-11 13:14:54 -0700)

are available in the Git repository at:

  https://github.com/vimproved/liburing.git print-libgcc-file-name

for you to fetch changes up to 09b8ded9686f33f1044ad8c612f2281b865cd314:

  Link against libgcc based on output of -print-libgcc-file-name (2023-12-16 16:28:20 -0500)

----------------------------------------------------------------
Violet Purcell (1):
      Link against libgcc based on output of -print-libgcc-file-name

 configure    | 9 +++++++++
 src/Makefile | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)
Click to show/hide pull request guidelines

Pull Request Guidelines

  1. To make everyone easily filter pull request from the email
    notification, use [GIT PULL] as a prefix in your PR title.
[GIT PULL] Your Pull Request Title
  1. Follow the commit message format rules below.
  2. Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

  1. The first line is title (don't be more than 72 chars if possible).
  2. Then an empty line.
  3. Then a description (may be omitted for truly trivial changes).
  4. Then an empty line again (if it has a description).
  5. Then a Signed-off-by tag with your real name and email. For example:
Signed-off-by: Foo Bar <foo.bar@gmail.com>

The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).

Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue
URL.

Don't use GitHub anonymous email like this as the commit author:

123456789+username@users.noreply.github.com

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <axboe@kernel.dk>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

@vimproved
Link against libgcc based on output of -print-libgcc-file-name
09b8ded 
GCC and clang have the -print-libgcc-file-name option to automatically
print out the correct compiler runtime library to link to. This can be
helpful in case the runtime library is named something other than libgcc
(i.e. on a system where only LLVM's compiler-rt is used), or if libgcc
is in a non-standard directory. If the option fails for whatever reason,
fall back to using "-lgcc".

Signed-off-by: Violet Purcell <vimproved@inventati.org>
@axboe axboe merged commit bbd2749 into axboe:master Dec 18, 2023
13 checks passed
@NickCao NickCao mentioned this pull request Jun 16, 2024
Closed
@RossComputerGuy RossComputerGuy mentioned this pull request Jun 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimproved @axboe